Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the attributes with dependencies on other attributes to the recipes #150

Merged
merged 7 commits into from
Mar 29, 2017

Conversation

artem-sidorenko
Copy link
Member

@artem-sidorenko artem-sidorenko commented Mar 28, 2017

See this for more details.

CI is red and should get green after #149 is merged and this PR is rebased on top

Review commit-by-commit is a good idea here

@coveralls
Copy link

coveralls commented Mar 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c5d0670 on artem-sidorenko:attrs-this-time-really into c9c3a8b on dev-sec:master.

in the recipe. Otherwise we can not really rely on the value
of dependency attribute
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 09054ee on artem-sidorenko:attrs-this-time-really into e493b0f on dev-sec:master.

@artem-sidorenko
Copy link
Member Author

@atomic111 its rebased now :)

@atomic111
Copy link
Member

@artem-sidorenko thanks for this great work, we get closer to 2.0

@atomic111 atomic111 merged commit 65fd503 into dev-sec:master Mar 29, 2017
@artem-sidorenko artem-sidorenko deleted the attrs-this-time-really branch April 6, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants